Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CableRepository to Model #205

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

SeanBryan51
Copy link
Collaborator

Changes in preparation for #183.

Fixes #204

@SeanBryan51 SeanBryan51 linked an issue Nov 17, 2023 that may be closed by this pull request
@SeanBryan51 SeanBryan51 force-pushed the 204-rename-CableRepository-to-Model branch from 65bdec5 to bb7ab15 Compare November 17, 2023 01:34
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (505bc50) 85.19% compared to head (bb7ab15) 85.19%.
Report is 1 commits behind head on main.

Files Patch % Lines
benchcab/benchcab.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          27       27           
  Lines        1391     1391           
=======================================
  Hits         1185     1185           
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SeanBryan51 SeanBryan51 merged commit 067b1f4 into main Nov 19, 2023
4 checks passed
@SeanBryan51 SeanBryan51 deleted the 204-rename-CableRepository-to-Model branch November 19, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename repository.py to model.py and CableRepository to Model
2 participants