Add getter method for built executable #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 85.19% 85.24% +0.05%
==========================================
Files 27 27
Lines 1391 1396 +5
==========================================
+ Hits 1185 1190 +5
Misses 206 206 ☔ View full report in Codecov by Sentry. |
This change removes any hard coded paths to the built executable that are outside the `CableRepository` class and replaces these with a method that returns the path to the executable. This is done to prepare for the changes in #183 which requires paths to vary accross different `CableRepository` objects. Fixes #199
SeanBryan51
force-pushed
the
199-add-getter-for-exe-path
branch
from
74bee79
to
e9110fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes any hard coded paths to the built executable that are outside the
CableRepositoryclass and replaces these with a method that returns the path to the executable. This is done to prepare for the changes in #183 which requires paths to vary accross differentCableRepositoryobjects.Fixes #199