Add support for checking out GitHub repositories #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 85.37% 82.67% -2.71%
==========================================
Files 27 28 +1
Lines 1409 1495 +86
==========================================
+ Hits 1203 1236 +33
- Misses 206 259 +53 ☔ View full report in Codecov by Sentry. |
SeanBryan51
force-pushed
the
183-github-repository-support
branch
3 times, most recently
from
b76d177
to
6f586a1
Compare
ccarouge
requested changes
Nov 21, 2023
Comment on lines
+22
to
+28
| realisations: | ||
| - repo: | ||
| svn: | ||
| branch_path: trunk | ||
| - repo: | ||
| svn: | ||
| branch_path: branches/Users/ccc561/v3.0-YP-changes |
There was a problem hiding this comment.
Should we change this to git? BTW, the svn config isn't valid anymore, I deleted the branches/Users/ccc561/v3.0-YP-changes branch.
There was a problem hiding this comment.
@bschroeter was config-valid.yml example meant to be exhaustive in the config options or just a simple success case to test the schema validation? If the latter then this probably isn't necessary since the config is still valid from a validation perspective?
Yes you are right. I think you are referring to this line: Lines 40 to 41 in 6f586a1 This is why writing tests forces you to write better code 😆. The I'm happy to add a comment here so that this gets addressed. |
|
Here is an integration that checks out and builds an SVN repo and a Git repo: #!/bin/bash
bench_example_dir='bench_example_test_build_git_and_svn'
rm -rf $bench_example_dir
git clone [email protected]:CABLE-LSM/bench_example.git $bench_example_dir
cd $bench_example_dir
git reset --hard 6287539e96fc8ef36dc578201fbf9847314147fb
cat > config.yaml << EOL
project: tm70
experiment: AU-Tum
realisations:
- repo:
svn:
branch_path: trunk
- repo:
git:
branch: main
modules: [
intel-compiler/2021.1.1,
netcdf/4.7.4,
openmpi/4.1.0
]
EOL
benchcab checkout -v && benchcab build -v |
Yes, add a comment and an issue and that's good as is for now. |
This was referenced Nov 22, 2023
SeanBryan51
added a commit
that referenced
this pull request
Nov 22, 2023
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
SeanBryan51
added a commit
that referenced
this pull request
Nov 22, 2023
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
SeanBryan51
added a commit
that referenced
this pull request
Nov 22, 2023
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
PR: #208 Co-authored-by: Claire Carouge <[email protected]>
SeanBryan51
force-pushed
the
183-github-repository-support
branch
from
bf6d8df
to
6e7fde8
Compare
SeanBryan51
added a commit
to CABLE-LSM/bench_example
that referenced
this pull request
Nov 23, 2023
Changes part of: CABLE-LSM/benchcab#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently benchcab can only fetch repositories from the subversion repository. This change adds the ability to specify and checkout repositories from GitHub so that benchcab can be used when CABLE moves over to Git.
Fixes #183, #197