-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tests on standard output #222
Conversation
This change removes any assertions on standard output from the tests so that tests focus on testing functionality (where possible) rather than the messages (print statements) that are emitted from the tested functions. Fixes #221
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 82.68% 82.42% -0.26%
==========================================
Files 28 28
Lines 1496 1417 -79
==========================================
- Hits 1237 1168 -69
+ Misses 259 249 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so the tests have been removed - thanks. But did we want to look at reimplementing them with subprocess-mock? Or update to test end-to-end (i.e. existence of files etc.) rather than on stdout?
I'm happy to switch to subprocess-mock in our unit testing however this might be better to do in a separate PR. Is this what you are suggesting? |
That makes sense. Let's just accept that coverage will go down, but we should raise another issue to re-engineer these tests to ensure that we're covered for the functionality going forward. |
Also just to clarify, is subprocess-mock referring to the pytest-subprocess pytest plugin that you have been working with? |
This change removes any assertions on standard output from the tests so that tests focus on testing functionality (where possible) rather than the messages (print statements) that are emitted from the tested functions.
Fixes #221