Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove svn dependency in default runs #236

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

abhaasgoyal
Copy link

@abhaasgoyal abhaasgoyal commented Jan 19, 2024

Fixes #230

Merge Message
When running benchcab, it checks out on svn branch, potentially for data files like GRID_DATA. This commit:

  • Removes the dependency to check out in svn branch
  • Cleans up internal variables for unused files
  • Uses alternative sources for existing data files in svn - testing was done via bitwise comparison generated by main vs 230-remove-svn-dependency branch during integration tests

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e875575) 58.23% compared to head (d1d6280) 58.22%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   58.23%   58.22%   -0.01%     
==========================================
  Files          29       29              
  Lines        2114     2109       -5     
==========================================
- Hits         1231     1228       -3     
+ Misses        883      881       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhaasgoyal
Copy link
Author

@ccarouge can you run benchcap for comparison on CABLE_AUX?

@ccarouge
Copy link
Collaborator

ccarouge commented Jan 22, 2024

Comparison of benchcab with the gridinfo file from CABLE-AUX branch and with a gridinfo file in rp23 has been done. It has shown differences in the results. This is surprising and might require further investigation on the CABLE side later on.

To move on here, we will look at adding the CABLE-AUX data under /g/data/wd9 for the moment. This will change once we have a well-documented gridinfo file we can use instead.

@abhaasgoyal abhaasgoyal changed the title DRAFT: Remove svn dependency in default runs Remove svn dependency in default runs Jan 22, 2024
Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one small change to make before merging. I'm approving because I don't think I need to review again after that change but feel free to ask anyway if you want to.

Once the change is done, you are free to merge (not squash or rebase please).

benchcab/data/test/integration.sh Outdated Show resolved Hide resolved
@abhaasgoyal abhaasgoyal merged commit d457639 into main Jan 23, 2024
5 checks passed
@abhaasgoyal abhaasgoyal deleted the 230-remove-svn-dependency branch January 23, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency of checking out CABLE-AUX from SVN
2 participants