Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest using local conda installation #265

Merged

Conversation

SeanBryan51
Copy link
Collaborator

@SeanBryan51 SeanBryan51 commented Mar 12, 2024

This change improves the CI to detect missing dependencies in meta.yaml by running pytest with the dependencies that come installed with a local benchcab install.

This PR should go in after #266 so we can verify the CI is working as intended.

Fixes #264

@SeanBryan51 SeanBryan51 linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (ac2cb1f) to head (3246f08).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   63.84%   63.93%   +0.09%     
==========================================
  Files          35       35              
  Lines        2597     2612      +15     
==========================================
+ Hits         1658     1670      +12     
- Misses        939      942       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeanBryan51 SeanBryan51 force-pushed the 264-ci-doesnt-pick-up-on-missing-dependencies-in-metayaml branch 28 times, most recently from 4f581d5 to d581938 Compare March 14, 2024 05:14
@SeanBryan51 SeanBryan51 force-pushed the 264-ci-doesnt-pick-up-on-missing-dependencies-in-metayaml branch 11 times, most recently from ec9199d to 7288acb Compare March 15, 2024 01:47
@SeanBryan51 SeanBryan51 marked this pull request as ready for review March 15, 2024 01:55
@SeanBryan51 SeanBryan51 changed the title Test conda install in CI Run pytest using local conda installation Mar 15, 2024
@SeanBryan51 SeanBryan51 requested review from a team and ccarouge and removed request for a team March 15, 2024 03:41
Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

This verifies the test suite can run using the dependencies defined in
meta.yaml.
@SeanBryan51 SeanBryan51 force-pushed the 264-ci-doesnt-pick-up-on-missing-dependencies-in-metayaml branch from 7288acb to 3246f08 Compare March 19, 2024 04:59
@SeanBryan51 SeanBryan51 merged commit a124abd into main Mar 19, 2024
4 checks passed
@SeanBryan51 SeanBryan51 deleted the 264-ci-doesnt-pick-up-on-missing-dependencies-in-metayaml branch March 19, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't pick up on missing dependencies in meta.yaml
2 participants