Use package_data configuration option #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 63.84% 63.93% +0.09%
==========================================
Files 35 35
Lines 2597 2612 +15
==========================================
+ Hits 1658 1670 +12
- Misses 939 942 +3 ☔ View full report in Codecov by Sentry. |
Merged
SeanBryan51
requested review from
a team and
Whyborn
and removed request for
a team
|
Looks fine to merge to me. |
Currently the uploaded tarball for benchcab v4.0.0 is missing the site-packages/benchcab/data directory (see https://anaconda.org/accessnri/benchcab/files). This change fixes this by replacing the include_package_data option with the package_data option in setup.cfg (see Data Files Support). Conda package deployment was tested here in a forked repository and the uploaded tarball contains the package data directory. Fixes #267
SeanBryan51
force-pushed
the
267-fix-missing-package-data
branch
from
8794d89
to
0933e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the uploaded tarball for benchcab v4.0.0 is missing the site-packages/benchcab/data directory (see https://anaconda.org/accessnri/benchcab/files). This change fixes this by replacing the
include_package_dataoption with thepackage_dataoption in setup.cfg (see Data Files Support).Conda package deployment was tested here in a forked repository and the uploaded tarball contains the package data directory.
Fixes #267