Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

updated sql script to make login_gov_email column nullable #11

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

deandreJones
Copy link

Jira ticket

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Setup to Run the Code

How to test

  1. Access the
  2. Login as a

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@deandreJones deandreJones merged commit 5b19d40 into E-04371-Okta Aug 17, 2023
7 checks passed
@danieljordan-caci danieljordan-caci deleted the B-17150-DB-UPDATES-OKTA branch September 1, 2023 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants