Feture/new command structure #4
Conversation
src/main.rs
Outdated
| #[derive(Subcommand, Debug, Clone)] | ||
| enum Commands { | ||
| /// Create new C Proejct with name | ||
| CNew { |
There was a problem hiding this comment.
Agree with clippy here, I think prefixes in Enum variants are redundant.
Please remove the C prefix for each variant.
The project itself is named cinit and in the description/Readme describes that it is creating a C language tool, so it is not needed to prefix with c in functions variants and whatever.
src/main.rs
Outdated
| /// Build ./src/*.c files and moved to ./bin/ | ||
| BuildC, | ||
| /// Build and run project | ||
| BulidCRunC, | ||
| } | ||
|
|
||
| #[derive(Clone)] | ||
| struct Cinit(Args); | ||
|
|
| } | ||
|
|
||
| fn c_new(project_name: &String, lib: Option<String>) -> Result<(), Box<dyn std::error::Error>> { | ||
| create_sub_directory(project_name, "src")?; |
There was a problem hiding this comment.
Remove the prefix from the name of the function
| println!("Content written to {}", file_dir); | ||
| } | ||
| fn build_c() -> Result<(), std::io::Error> { | ||
| // Ejecutar GCC para compilar el programa |
src/main.rs
Outdated
| .args(["src/main.c", "-Wall", "-o", "main"]) | ||
| .status() | ||
| .expect("Failed to execute GCC"); | ||
|
|
There was a problem hiding this comment.
I think this command should be using the build system selected by the user.
If the user selects that wants a Makefile in the project I think this command should execute make
And you should consider the possibility of a different build system. For example nob , our dear friend tsoding is using it in their projects.
There was a problem hiding this comment.
For the moment the build command will only compile using gcc. Future versions will accept the build system selected by the user.
There was a problem hiding this comment.
Put an issue and reference the issue in this conversation then
There was a problem hiding this comment.
I have created the issue referring to your suggestion #6
src/main.rs
Outdated
| build_c()?; | ||
| //println!("{:?}", std::env::current_dir()) | ||
| } | ||
| Commands::BulidCRunC => eprintln!("Developing"), |
There was a problem hiding this comment.
I think you can just use todo!() macro if this feature is not developed yet and the compiler will shut the fuck up
New command structure to be able to create new project and build the project