-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterating on Simulator Design for Sampling #297
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aded correctly TODO implement the GazeModel and transfer to offline analysis
…ns; added parameters for rows and columns.
Passive device bug
Random uniform
Matrix Grid Always On
# Conflicts: # bcipy/simulator/helpers/log_utils.py
Logging fix
Refactoring data engine helper
# Conflicts: # .gitignore # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Focused on high-level design for the simulator. Modularized parts of the simulator so we can iterate on designs more easily. This draft PR is mostly just to share code easily. The goal was to create a simple data ingestor and sampler that could sample by letter from multiple data sources. View
sim_test.py
for examples of use.I think the replay session logic will fit into this design without any change as well. The sampler would just be an iterator, that I implemented in the previous design. The DataEngine would load in-session data instead, which is also already implemented.
Ticket
Link a pivotal ticket here
Contributions
DataEngine
,Sampler
,MetricReferee
,ModelHandler
,StateManager
RawDataEngine
andSimpleLetterSampler
, which can successfully load in multiple data sources, organize into queryable schema, and return eeg samples that can be fed into SignalModelStateManager
that handles a lot of the updating logic from inquiry to inquiryStarted but unfinished
sim_sampler.py
MetricReferee
,ModelHandler
, all have unfinished implementationsStateManager
is a bit naive right now. There is also an issue with how I'm evaluating evidence because the simulator is always making a decision; albeit, mostly wrong ones.Test
-No unit testing yet, just ran script to test sampling and data loading in
sim_test.py
Documentation
Changelog