Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Status #310

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Device Status #310

merged 3 commits into from
Jan 10, 2024

Conversation

lawhead
Copy link
Collaborator

@lawhead lawhead commented Jan 6, 2024

Overview

Added active/passive status to devices.

Ticket

https://www.pivotaltracker.com/story/show/186164071

Contributions

  • Added a new field to DeviceSpec for the device status. Updated the loading / saving code to read/write the field. Updated devices.json to use a default value of 'active'.
  • Updated acquisition.py module to allow for setting this field using the parameters.
  • Updated offline_analysis to only train models for active devices.
  • Updated Copy Phrase task to only create evidence_evaluators for active devices.
  • Added unit tests

Test

  • Ran all unit tests
  • Ran a calibration task with "acq_mode": "EEG+Eyetracker:passive", followed by offline analysis to confirm that only the EEG model was trained. Changed the devices.json in the calibration folder, ran the offline analysis, and confirmed that the code attempted to train both models.

@lawhead lawhead requested review from tab-cmd and celikbasak January 6, 2024 00:50
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

I looked around and couldn't find any documentation on configuring devices. I'm not sure what the best location would be, but a small blurb about setting active/passive in the main README could be helpful (maybe near the core modules section).

@lawhead
Copy link
Collaborator Author

lawhead commented Jan 9, 2024

Ugh, sorry about that. I forgot to push the commit with the documentation.

@lawhead lawhead merged commit afce143 into 2.0.0rc4 Jan 10, 2024
4 of 6 checks passed
@lawhead lawhead deleted the device-recording-status branch January 10, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants