Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session orchestrator #339

Merged
merged 249 commits into from
Oct 23, 2024
Merged

Session orchestrator #339

merged 249 commits into from
Oct 23, 2024

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Aug 21, 2024 •
edited
Loading

Overview

This PR refactors how BciPy runs and handles its Task executions. It supports the notion of Experiment Protocols, which the orchestrator can use to run multiple Tasks.

Tickets

Open Questions

  • Naming Orchestrator vs SessionOrchestrator

Contributions

  • Add SessionOrchestrator
  • Add Protocol support
  • Add Actions
  • Refactor ExperimentGUI
  • Add parameter guardrails: functionality still in progress
  • Add support running multiple copy phrases with phrases.json
  • Update READMEs
  • Bug fix font issues
  • Add TaskMode and fix paradigm definitions in Tasks
  • Add Task Specific Parameters
  • Move exceptions to root
  • Deprecate add_missing_parameters functionality (for now)

Test

  • make test-all
  • demo_orchestrator.py with all Calibrations and Multiple Copy Phrases
    • ensured presentation was as expected
    • ensured parameters.json saved correctly with phrases.json was used
  • demo_bci_main.py
  • Time testings
  • Pilot testing: complete!

Documentation

  • Are documentation updates required? In-line, README, or documentation? README and docstrings updated.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? Done!

Carsonthemonkey and others added 30 commits March 11, 2024 12:23
@Carsonthemonkey
Add work in progress session orchestrator module
a249413
@Carsonthemonkey
gets main.py functionality working in the orchestrator
a01ea1c
@Carsonthemonkey
Fixes task initialization process
a7f226d 
Save folder and parameters are now saved and loaded per task as they are executed rather than once per session
@Carsonthemonkey
adds some orchestrator tests
89b5b9e
@Carsonthemonkey
Cleans up session_orchestrator.py
305a739 
Removes some commented out code, and lints file
@Carsonthemonkey
Moves paramter loading to task execution
a2b0660
@Carsonthemonkey
Adds functions for parsing visit actions
e07ac7e
@Carsonthemonkey
Adds some test to action parsing
db4e90b
@Carsonthemonkey
Adds tests for action serialization
5603ab2
@Carsonthemonkey
Adds parameter validation function with tests
d917542
@Carsonthemonkey
Updates changelog.md
db859e9
@Carsonthemonkey
Fixes formatting error in changelog.md
827d109
@Carsonthemonkey
lints actions.py and test_actions.py
be63589
@Carsonthemonkey
Adds orchestrator options to the parameters.json file
428672d
@Carsonthemonkey
Adds constant for action seperator
6985b17
@Carsonthemonkey
removes old file that has been moved
4fb3186
@Carsonthemonkey
renames action parsing module and updates test imports
30fb351
@Carsonthemonkey
simplifies serialize_actions function
824c59c
@Carsonthemonkey
Fixes typing and formatting issues
afd6083
@Carsonthemonkey
removes parse_actions.py
38304a3
@Carsonthemonkey
renames parse_actions to parse_sequence
4c19fed
@Carsonthemonkey
replaces magic '->' string with constant
2a5da70
@Carsonthemonkey
removes unnecessary error check
180c6e5
@Carsonthemonkey
Merge pull request #320 from CAMBI-tech/orchestrator_parameters
1103585 
Orchestrator parameters
@Carsonthemonkey
Adds basic structure for orchestrator actions
81d1727
@Carsonthemonkey
refactors config function naming and adds support for actions in pars…
e6e7fcc 
…ing functions
@Carsonthemonkey
renames test_actions to test_config
47b3ec9
@Carsonthemonkey
Adds additional tests for action parsing
64393da
@Carsonthemonkey
Adds action serialization tests
6630561
@tab-cmd
Add more actions
a67693b
Carsonthemonkey and others added 27 commits August 30, 2024 16:00
@Carsonthemonkey
rename intertask_action to intertask_gui
90554c4
@Carsonthemonkey
add action that displays intertask GUI
4a260ac
@Carsonthemonkey
Add proper types and docs to bciui
8cb3dfb
@Carsonthemonkey
Deprecates old ExperimentRegistry in favor of new ui code
2236b10
@Carsonthemonkey
Fixes incorrect background color when using dark mode
30badae
@Carsonthemonkey
improve stylsheet loading to use existing bcipy constants
81d619f
@Carsonthemonkey
update legacy BCInterface to base session-orchestrator
0e63870
@Carsonthemonkey
Merge branch 'session-orchestrator' into bci_gui_rewrite
3f43224
@Carsonthemonkey
lints code
3664c3d
@Carsonthemonkey
Merge pull request #337 from CAMBI-tech/bci_gui_rewrite
a40d003 
Bci gui rewrite
@tab-cmd
Session Orchestrator Updates [Post-Testing] (#344)
6014478 
* TODO better catch exceptions

See Discord notes

* Add logger to each task run

* Add logger to Task tests, remove bci_main tests for now

TODO: mock copy phrase model loading in tests

* update tests and fix typing

* linting
@tab-cmd
Bcipy client refactor (#346)
b80f7fe
@tab-cmd
Merge branch '2.0.0rc4' into session-orchestrator
79b9f0c
@tab-cmd
cleanup
3b145cb
@tab-cmd
Task specific params and Matrix Layout (#349)
e4d3248
@tab-cmd
Orchestrator - Load a JSON of copy phrases to use during execution (#352
e873a4a 
)
@tab-cmd
Merge branch '2.0.0rc4' into session-orchestrator
31517bb
@tab-cmd
Updates after merging
6bfa2b2
@tab-cmd
updates after merging
ac3d5ab
@tab-cmd
fix logger assignment
a531946
@tab-cmd
BciPy report action, offline analysis updates, Intertask GUI. (#354)
0dd8b50
@tab-cmd
Merge remote-tracking branch 'origin/2.0.0rc4' into session-orchestrator
b8bd254
@tab-cmd
updates to include IP changes
4e6dcc5
@tab-cmd
Update to get static offset from the device
9c6e6f4
@tab-cmd
Merge remote-tracking branch 'origin/session-orchestrator' into sessi…
5aa493a 
…on-orchestrator
@tab-cmd
update action tests
fd80bd3
@tab-cmd
lint
02d8eb3
@tab-cmd tab-cmd marked this pull request as ready for review October 23, 2024 18:01
@tab-cmd tab-cmd merged commit a635baa into 2.0.0rc4 Oct 23, 2024
6 checks passed
@tab-cmd tab-cmd deleted the session-orchestrator branch October 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tab-cmd @Carsonthemonkey @lawhead