Fusion model patch for 2.0.1rc4 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tab-cmd
requested changes
Nov 15, 2024
tab-cmd
reviewed
Nov 25, 2024
tab-cmd
reviewed
Nov 25, 2024
Try running on GitHub
Remove in Ubuntu (bug ticket created)
mark slower tests
|
Thank you so much for your updates/bug fixes Tab!! |
|
@celikbasak This needs documentation (README and docstring) and an integration test. Then, it can be merged! If you can tackle the documentation, I will add some tests. |
tab-cmd
reviewed
Dec 10, 2024
|
|
||
| def evaluate(self, test_data: np.ndarray, test_labels: np.ndarray): | ||
| ... | ||
| class GaussianProcess(SignalModel): |
There was a problem hiding this comment.
This is missing several important methods. It doesn't seem like it could be used online as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Offline analysis workflow change, fusion model training-testing added, bugfix in gaze reshaper & gaze model.
Ticket
Contributions
Fusion.pyadded for generating model performance measures.Test
Documentation
Changelog