Skip to content

Commit

Permalink
Warning fixes (#121)
Browse files Browse the repository at this point in the history
* disabled CA1416 as it should only run on windows
* Fixed buildDate cannot be null warning
* Fixed WFAC010 warning about the HighDPImode in manifest
  • Loading branch information
nimrof authored Oct 6, 2024
1 parent 86294fb commit 6d02e11
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
4 changes: 4 additions & 0 deletions EDSEditorGUI/EDSEditorGUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,17 @@
<UseWindowsForms>true</UseWindowsForms>
<ImportWindowsDesktopTargets>true</ImportWindowsDesktopTargets>
<EmbeddedResourceUseDependentUponConvention>true</EmbeddedResourceUseDependentUponConvention>
<ApplicationHighDpiMode>SystemAware</ApplicationHighDpiMode>
</PropertyGroup>
<PropertyGroup>
<ApplicationIcon>Index_8287_16x.ico</ApplicationIcon>
</PropertyGroup>
<PropertyGroup>
<ApplicationManifest>app.manifest</ApplicationManifest>
</PropertyGroup>
<PropertyGroup>
<NoWarn>$(NoWarn);CA1416</NoWarn>
</PropertyGroup>
<ItemGroup>
<Reference Include="Microsoft.mshtml, Version=7.0.3300.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
<SpecificVersion>False</SpecificVersion>
Expand Down
12 changes: 0 additions & 12 deletions EDSEditorGUI/app.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,6 @@
</application>
</compatibility>

<!-- Indicates that the application is DPI-aware and will not be automatically scaled by Windows at higher
DPIs. Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need
to opt in. Windows Forms applications targeting .NET Framework 4.6 that opt into this setting, should
also set the 'EnableWindowsFormsHighDpiAutoResizing' setting to 'true' in their app.config. -->

<application xmlns="urn:schemas-microsoft-com:asm.v3">
<windowsSettings>
<dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
</windowsSettings>
</application>


<!-- Enable themes for Windows common controls and dialogs (Windows XP and later) -->
<!--
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion libEDSsharp/CanOpenXDD.cs
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ public EDSsharp convert(ISO15745ProfileContainer container)
productID = ApplicationLayers.identity.productID.Value;
}

if (ApplicationLayers.identity.buildDate != null)
if (ApplicationLayers.identity.buildDate != default)
{
buildDate = ApplicationLayers.identity.buildDate;
}
Expand Down

0 comments on commit 6d02e11

Please sign in to comment.