bugfix defaultvalue: Do not ask to take new default value to all sub if new default is the same

EDSEditorGUI/DeviceODView.cs

@@ -532,7 +532,46 @@ private void ObjectSave()
                     od.prop.CO_accessSRDO = AccessSRDO.no;
                 }
 
-                od.defaultvalue = textBox_defaultValue.Text;
+                // Default value
+                if (listView_subObjects.SelectedItems.Count > 1) {
+                    for (ushort i = 0; i < listView_subObjects.SelectedItems.Count; i++)
+                    {
+                        od.parent.subobjects[(ushort) Convert.ToInt32(listView_subObjects.SelectedItems[i].Text,16)].defaultvalue = textBox_defaultValue.Text;
+                    }
+                }
+
+
+                bool setDefaultValueToAll = false;
+                bool identicalDefaultValues = true;
+
+                if (od.parent != null && od.parent.Nosubindexes > 2)
+                {
+
+                    for (int i = 2; i < od.parent.Nosubindexes; i++)
+                    {
+                        identicalDefaultValues &= ((od.parent.subobjects[(ushort)i].defaultvalue == od.parent.subobjects[(ushort)(i - 1)].defaultvalue) && (od.parent.subobjects[(ushort)i].defaultvalue != textBox_defaultValue.Text));
+                    }
+
+                    if (identicalDefaultValues) {
+                            DialogResult confirm = MessageBox.Show("Do you want to set all identical default values in subobjects to this default value?", "Set to all?", MessageBoxButtons.YesNo);
+                        if (confirm == DialogResult.Yes)
+                        {
+                            setDefaultValueToAll = true;
+                        }
+                    }
+                }
+                        if (setDefaultValueToAll)
+                {
+                    for (ushort i = 1; i < od.parent.Nosubindexes; i++)
+                    {
+                            od.parent.subobjects[i].defaultvalue = textBox_defaultValue.Text;
+                    }
+                }
+                else
+                {
+                    od.defaultvalue = textBox_defaultValue.Text;
+                }
+
                 od.actualvalue = textBox_actualValue.Text;
                 od.HighLimit = textBox_highLimit.Text;
                 od.LowLimit = textBox_lowLimit.Text;

EDSEditorGUI/DevicePDOView2.cs

@@ -460,7 +460,12 @@ public void UpdatePDOinfo(bool updatechoices = true)
                 int ordinal = 0;
                 foreach (ODentry entry in slot.Mapping)
                 {
+                    if ((bitoff + entry.Sizeofdatatype()) > 64)
                     {
+                       string toDisplay = string.Join(Environment.NewLine, slot.Mapping);
+                       MessageBox.Show(string.Format("Invalid TXPDO mapping parameters in 0x{0:X}!\r\nTrying to map more than the maximum lenght of a CAN message (8 bytes).\r\n\r\nMembers are:\r\n{1}", slot.ConfigurationIndex,toDisplay));
+                        break;
+                    }
                         string target = slot.getTargetName(entry);
                         grid1[row + 2, bitoff + 3] = new SourceGrid.Cells.Cell(target, comboStandard);
                         grid1[row + 2, bitoff + 3].ColumnSpan = entry.Sizeofdatatype();
@@ -480,14 +485,9 @@ public void UpdatePDOinfo(bool updatechoices = true)
 
                         grid1[row + 2, bitoff + 3].AddController(vcc);
                         bitoff += entry.Sizeofdatatype();
-                    }
 
-                    ordinal++;
 
-                    if (bitoff > 64) {
-                        MessageBox.Show(string.Format("Invalid TXPDO mapping parameters in 0x{0:X}. Trying to map more than 64 bit (8 Bytes). CAN message maximum lenght is 8 Byte", slot.ConfigurationIndex));
-                        break;
-                    }
+                    ordinal++;
 
                 }