-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BMZ README #322
Update BMZ README #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems all good!
Although I recently uploaded a model including a ## Validation
section in doc.md
, I get the No '# Validation' (sub)section found in doc.md.
warning! 😕
I guess they expect it as an h1
header which sucks!!
Should the validation section suggest metrics to use? E.g. PSNR, SSIM or MicroSSIM? Also is there a paper or somewhere that explains looking at the residuals in a bit more detail that can be linked to ? |
That's a good idea! |
That means that the specs that @melisande-c pointed to are wrong. Can you open an issue or correct it? (I don't remember where it was) |
Regarding the residual, I want to run some tests soon and add a convenience function to CAREamics to look at the statistics of the residual as a proxy for how much real signal is still present in the residual. I'd leave at that for now, and revisit once we have more concrete stuff. |
Description
Following #278, this PR reorganizes the exported BMZ README:
In addition, the API for the BMZ export has changed:
data_description
is now mandatorymodel_version
is an optional parameter allowing to version modelscover
is an optional parameterUsers can now provide a path to a cover, no validation is done of that path. If no cover is provided, then we do something that is probably not optimized for multichannels:
blue
andgreen
Note that that this is not a great way to represent scientific data, we should apply LUT to the grey scale channels and recompose overlays. Look up tables have been worked out for scientific figures and we could use those.
If that is acceptable for now, it will be easy to replace it.
Changes Made
cover_factory.py
Related Issues
#278
#176
Breaking changes
Any call to
careamist.export_bmz
.Additional Notes and Examples
The results README looks like this:
Please ensure your PR meets the following requirements: