Fix: Change tqdm import so it automatically detects whether it is rendering within a notebook #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
tldr: tqdm has functionality to automatically detect whether it is rendering from within a notebook or not, but it has to be imported from
tqdm.auto
. Doing this will improve the rendering of progress bars within notebooks. See tqdm docsBackground - why do we need this PR?
Progress bar rendering was pretty ugly within notebooks, especially when using jupyter directly.
Overview - what changed?
tqdm import.
Implementation - how did you implement the changes?
Do
from tqdm.auto import tqdm
instead ofimport tqdm
.Changes Made
Modified features or files
careamics/lightning/callbacks/progress_bar_callback.py
How has this been tested?
Please ensure your PR meets the following requirements: