Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop polling issues when creating new team response #1283

Merged

Conversation

nknguyenhc
Copy link
Contributor

Summary:

Fixes #1282

Changes Made:

  • In IssueService, created a new boolean field isCreatingTeamResponse.
  • Change the value of the field when creating team response.
  • Use the field to stop polling issue

Note: I did not change the order of API calls in view of #1264

Proposed Commit Message:

Before this, team response might be created
at right the moment the issue is being polled.
This causes the error message to pops up,
as request to update label has been processed,
but request to create comment has not.

Before this, team response might be created
at right the moment the issue is being polled.
This causes the error message to pops up,
as request to update label has been processed,
but request to create comment has not.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.50%. Comparing base (5e7ed48) to head (203b78d).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/app/core/services/issue.service.ts 14.28% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
+ Coverage   54.82%   58.50%   +3.67%     
==========================================
  Files         105      104       -1     
  Lines        2858     2574     -284     
  Branches      503      290     -213     
==========================================
- Hits         1567     1506      -61     
+ Misses       1030     1017      -13     
+ Partials      261       51     -210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent implementation of a simple flag to track status of team response updates.
LGTM!

@nknguyenhc nknguyenhc merged commit ef2d08d into CATcher-org:master Oct 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on saving response, showing an error message
3 participants