Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: jwt 토큰 추출 방식 개선 관련 user 패키지 리팩토링 (#137) #139

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

win-luck
Copy link
Contributor

@win-luck win-luck commented Jan 5, 2024

  • user 패키지 Dto에 빌더 패턴 적용
  • url에 담긴 userId(PathVariable) 에 직접 접근하는 구조에서 jwt토큰 수신하여 간접적으로 userId 추출하도록 수정
  • jwt토큰에서 userId 추출하는 메서드 반환값 String에서 Long으로 수정
  • 관련 테스트코드 수정
  • 테스트코드에선 jwt 인증을 생략하기 위한 TestConfig class 추가
  • 랭킹 관련 ResponseDto은 food 패키지와 의존성이 설정되어 있어 of 메서드 존치해둠, 추후 삭제 필요

@win-luck win-luck added the refactor 리팩토링 label Jan 5, 2024
@win-luck win-luck requested a review from synoti21 January 5, 2024 07:11
@win-luck win-luck self-assigned this Jan 5, 2024
@win-luck win-luck linked an issue Jan 5, 2024 that may be closed by this pull request
@win-luck win-luck changed the title Feature/refactor 137 Refactor: jwt 토큰 추출 방식 개선 관련 user 패키지 리팩토링 (#137) Jan 5, 2024
@synoti21
Copy link
Contributor

synoti21 commented Jan 5, 2024

후에 UserService의 'getUserInfo' 와 'getUserSimpleInfo'에 논의를 해야할 것 같습니다. 두 메서드의 목적이 겹쳐 경계가 조금 모호해진 것 같습닌다.

@synoti21 synoti21 merged commit 4f1c4fc into master Jan 5, 2024
1 check passed
@synoti21 synoti21 deleted the feature/refactor-137 branch January 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: user 패키지 리팩토링 (#137)
2 participants