Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minecraft): 1.21.5 snapshot (draft until 1.21.5 is released) #5549

Draft
wants to merge 63 commits into
base: nextgen
Choose a base branch
from

Conversation

DataM0del
Copy link
Contributor

@DataM0del DataM0del commented Feb 7, 2025

Still has errors.

@DataM0del DataM0del marked this pull request as draft February 7, 2025 02:02
@DataM0del
Copy link
Contributor Author

They renamed SwordItem to something else 💀
why???

@DataM0del
Copy link
Contributor Author

They probably removed it because datapack moment

@DataM0del
Copy link
Contributor Author

DataM0del commented Feb 7, 2025

I wonder if meteor client is updating to 1.21.5, maybe I can look at thatedit: nope

@DataM0del
Copy link
Contributor Author

Ok, I found the way, just use item tags 💀

@DataM0del
Copy link
Contributor Author

going back to look at the mc source because I can't find how to fix armor piece

@DataM0del
Copy link
Contributor Author

there's no way they removed the mining tool item class...

@@ -65,7 +65,7 @@
* This can be overridden by [PlayerInventoryConstraints] which introduces additional requirements.
*/
open fun passesRequirements(action: InventoryAction) =
(!requiresNoMovement || player.input.movementForward == 0.0f && player.input.movementSideways == 0.0f) &&
(!requiresNoMovement || !player.input.hasForwardMovement() && player.input.playerInput.left || player.input.playerInput.right) &&

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style. Warning

Line detected, which is longer than the defined maximum line length in the code style.
@DataM0del
Copy link
Contributor Author

only 99 errors left 🤑

@ccetl
Copy link
Contributor

ccetl commented Feb 7, 2025

Seems like they replaced BufferRenderer with drawing with a VertexBuffer. 1.21.4 (WorldBorderRendering.java#render):

if ((lv3 = lv2.endNullable()) != null) {
            BufferRenderer.drawWithGlobalProgram(lv3);
        }

...now in 1.21.5:

for (WorldBorder.class_10763 lv2 : border.method_67544(k, l)) {
            if (!(lv2.distance() < d)) continue;
            this.field_56591[lv2.direction().getHorizontalQuarterTurns()].draw(lv);
        }

No it's the same. The code regarding that did not change.
Okay i was on an outdated snapshot, it did change. But please reuse the VertexBuffers.


fun run() {
action.run()
}

// TODO: lol
override fun getAction(): ClickEvent.Action? {
return ClickEvent.Action.RUN_COMMAND
Copy link
Contributor

@ccetl ccetl Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, should have the same behavior as before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to override this otherwise it will error. What else am I going to do that won't cause an error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return null. And verify the logic, but i might do that myself later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return null. And verify the logic, but i might do that myself later.

Oh. 💀
hmm why ? at the end of the return type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants