-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minecraft): 1.21.5 snapshot (draft until 1.21.5 is released) #5549
base: nextgen
Are you sure you want to change the base?
Conversation
probably will need to fix some stuff too
…t know what hasCreativeInventory is in 1.21.5
…ode as a "hack fix"
…asCreativeInventory` with more hack fixes
They renamed SwordItem to something else 💀 |
They probably removed it because datapack moment |
|
Ok, I found the way, just use item tags 💀 |
src/main/kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/ModuleAutoWeapon.kt
Fixed
Show resolved
Hide resolved
.../kotlin/net/ccbluex/liquidbounce/features/module/modules/combat/autoarmor/ArmorEvaluation.kt
Fixed
Show resolved
Hide resolved
going back to look at the mc source because I can't find how to fix armor piece |
there's no way they removed the mining tool item class... |
…sage value is right
…ch,Yaw}` -> `last{Pitch,Yaw}`
… function & remove superclass params
… for some things
@@ -65,7 +65,7 @@ | |||
* This can be overridden by [PlayerInventoryConstraints] which introduces additional requirements. | |||
*/ | |||
open fun passesRequirements(action: InventoryAction) = | |||
(!requiresNoMovement || player.input.movementForward == 0.0f && player.input.movementSideways == 0.0f) && | |||
(!requiresNoMovement || !player.input.hasForwardMovement() && player.input.playerInput.left || player.input.playerInput.right) && |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
…s, going on to mixins...
only 99 errors left 🤑 |
...uex/liquidbounce/features/module/modules/render/murdermystery/MurderMysterySwordDetection.kt
Fixed
Show fixed
Hide fixed
|
src/main/kotlin/net/ccbluex/liquidbounce/features/command/commands/client/CommandConfig.kt
Outdated
Show resolved
Hide resolved
...lin/net/ccbluex/liquidbounce/features/command/commands/ingame/creative/CommandItemEnchant.kt
Outdated
Show resolved
Hide resolved
|
||
fun run() { | ||
action.run() | ||
} | ||
|
||
// TODO: lol | ||
override fun getAction(): ClickEvent.Action? { | ||
return ClickEvent.Action.RUN_COMMAND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, should have the same behavior as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to override this otherwise it will error. What else am I going to do that won't cause an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return null
. And verify the logic, but i might do that myself later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return
null
. And verify the logic, but i might do that myself later.
Oh. 💀
hmm why ?
at the end of the return type
literally just taken from 1.21.4 source, it just returns a List of the main hand item and the offhand item
… manager Co-authored-by: ccetl <[email protected]>
Still has errors.