Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Screen UI, centering buttons #144

Closed
wants to merge 2 commits into from

Conversation

Omegaviv
Copy link
Contributor

@Omegaviv Omegaviv commented Mar 4, 2022

Fixed Auth Screen UI

Before After

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@ItsAdityaKSingh
Copy link
Collaborator

@Omegaviv, this PR is resulting in unwanted UI behaviour and is conflicting itself with the changes suggested.

Screenshot -

You may test your changes for some other devices too if possible. Also, you would like to fetch the latest commits from the main branch :)

@Omegaviv
Copy link
Contributor Author

Omegaviv commented Mar 7, 2022

Oh yes my bad, I forgot to test for other devices.
Do you think it can be fixed using screenutil package?

@ItsAdityaKSingh
Copy link
Collaborator

Yeah, I guess screenutils or even sizer may be used for overcoming this :)

@ItsAdityaKSingh
Copy link
Collaborator

@Omegaviv Are you still working on this?

@ItsAdityaKSingh
Copy link
Collaborator

Closing for inactivity. Also, PR #175 addresses this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants