Feat: Added feature to preschedule a beacon + added local notifications at the start of prescheduled beacon #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into github_actions
GitHub actions
…into github_actions
GitHub actions
GitHub actions
devansh12b2
changed the title
nb9960
reviewed
Jan 17, 2022
There was a problem hiding this comment.
- There were overflow issues on create hike dialog box (adding the screenshot below for reference)
- User is able to create 2 hikes for the same start DateTime. I think when one is already leading a hike then creating another one should be restricted. But again it would be better to handle such validation from the backend itself.
- Tapping on notification should redirect to the hike_screen
- If beacon is not yet started then instead of redirecting to the hike screen it would be better to display snackbar depicting the same text. This would provide a better user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5 (partially only thing remaining is the deactivation of the beacon, which can only be implemented after addition of mutation at backend),