Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1618

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

IshanGrover2004
Copy link
Contributor

@IshanGrover2004 IshanGrover2004 commented Jun 20, 2024

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1499

Work to be done in this PR:

  • Change Dtvcc::new() to create Dtvcc using ccx_decoder_dtvcc_settings as done here
  • Create a new extern C fn ccxr_dtvcc_init() in lib.rs and use this at all places where dtvcc_init() is being called. (Probably add a new struct field to lib_cc_decode like dtvcc_rust and store Dtvcc there instead of using the dtvcc field)
  • Similar for dtvcc_free()
  • Change ccxr_process_cc_data to use Dtvcc from dec_ctx instead of creating a new one

Additionally to fix mp4 code flow:-

  • Call the corresponding rust function here and pass Dtvcc as done in the above steps

@IshanGrover2004 IshanGrover2004 marked this pull request as draft June 20, 2024 17:46
@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Jun 24, 2024

All checkmarks are done.

But with this sample file I am getting some memory leaks (in debug mode) -- error shown in here

Command used:

./ccextractor ~/Downloads/cc/test_dtvcc.ts --autoprogram --out=ttxt --latin1

@IshanGrover2004 IshanGrover2004 marked this pull request as ready for review June 24, 2024 18:35
@IshanGrover2004 IshanGrover2004 changed the title [WIP] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc Jun 24, 2024
@PunitLodha PunitLodha force-pushed the 1499-initialize-dtvcc-ds branch from c3a9eb0 to 9493e5e Compare June 27, 2024 10:50
@IshanGrover2004 IshanGrover2004 force-pushed the 1499-initialize-dtvcc-ds branch 2 times, most recently from baaeadb to fbc8aa3 Compare July 3, 2024 18:40
@PunitLodha
Copy link
Member

@IshanGrover2004 is this working fine now, after fixing the memory leaks?

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Aug 10, 2024

@IshanGrover2004 is this working fine now, after fixing the memory leaks?

Working fine for some samples @PunitLodha
Failing for some regression test, Have to thoroughly look into it for issues

@IshanGrover2004 IshanGrover2004 force-pushed the 1499-initialize-dtvcc-ds branch from fbc8aa3 to af42011 Compare August 10, 2024 11:44
@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Aug 10, 2024

Is there something wrong with the CI for regression test result msg? @canihavesomecoffee @prateekmedia

@IshanGrover2004
Copy link
Contributor Author

Some weeks before PR was ready.
But now when I again visited & ran sample on the rebase with master code, it just crashing at ccx_decoders_708_output.c:591 in dtvcc_writer_init

@IshanGrover2004 IshanGrover2004 force-pushed the 1499-initialize-dtvcc-ds branch from b3fcb1d to 294b9d9 Compare August 29, 2024 04:14
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90f9f0a...:

Report Name Tests Passed
Broken 10/13
CEA-708 6/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 14/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 81/86
Teletext 21/21
WTV 9/13
XDS 26/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 98a85e1...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 46/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize data structures correctly for the rust CEA-708 decoder
3 participants