Sample upload #13
Sample upload #13
Conversation
…both frontend and api
There was a problem hiding this comment.
I'm so glad to see this much progress, I'm pretty sure and have trust that you'd be able to deliver more than we thought during the second evaluations @zelzhan . Thanks a lot for working so hard <3
I've one small doubt that I've listed in comments. Apart from that, I want to know are we checking for file types that are allowed to be uploaded? Are we planning to have some whitelisting and blacklisting?
Also, I'm really poor at reviewing front-end code; I tend to not understand ti well. Therefore, I would be depending on you and the GIF and screenshots that you add in the description. Thanks for including a really awesome one covering everything from start to end this time.
| try { | ||
| this.service.writeToBucket(file); | ||
| } catch (error) { | ||
| return 'Error while writing the file to the bucket' |
There was a problem hiding this comment.
Does this handle sending appropriate error code as well?
There was a problem hiding this comment.
@zelzhan Can you please address my doubt here?
Key features:
../../../../../../every time, now the libraries can be accessed as follows :@new-sample-platform/api-implementation/libraryThe progress bar is filling immediately because I'm hosting locally and the speed of transfer is enormous