Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix apt-get installation errors in CI #541

Conversation

pranavrajpal
Copy link
Contributor

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

When running the CI for #540, the dependency installation failed when apt-get tried to install libvirt-dev, showing a message saying that it received a 404 error when trying to download packages (see https://github.com/CCExtractor/sample-platform/pull/540/checks?check_run_id=2542600517).

This appears to be related to actions/runner-images#2104, which suggests in actions/runner-images#2104 (comment) to try running apt-get update before installing anything.

Looking at the mirror that apt-get is trying to access, the problem it describes in that comment does appear to be what is happening here, as apt-get is trying to access deb files with ubuntu8.8 in them, but the mirror that it's connecting to has the same packages but with ubuntu8.9 in them instead.

Currently, when trying to install libvirt-dev for the CI run, apt-get
fails with a message saying that it received a 404 error when trying to
download packages.

This appears to be related to actions/runner-images#2104, which
seems to suggest a fix of running `apt-get update` before installing
anything.
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #541 (ad240f8) into master (e5da5aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files          36       36           
  Lines        3589     3589           
  Branches      408      408           
=======================================
  Hits         2905     2905           
  Misses        549      549           
  Partials      135      135           
Flag Coverage Δ
unittests 80.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5da5aa...ad240f8. Read the comment docs.

@canihavesomecoffee canihavesomecoffee merged commit eca27bd into CCExtractor:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants