Gradle update #627
Closed
Gradle update #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2025 15:04
…cted crashing of the app after launch
…n devices with android 13 or higher
|
I think using 8.10 is better in the root gradle wrapper properties since it aligns with the latest java version |
|
@ganidande905 I have tried that but many of the dependencies being used in the project do not support a java version higher than 19. Updating all the dependencies will result in a lot of code changes which I avoided. |
MarkisDev
requested changes
Jan 18, 2025
| @@ -30,7 +30,7 @@ void main() async { | |||
| final storage = Get.find<GetStorageProvider>(); | |||
| loc = await storage.readLocale(); | |||
|
|
|||
| final ThemeController themeController = Get.put(ThemeController()); | |||
| //final ThemeController themeController = Get.put(ThemeController()); | |||
There was a problem hiding this comment.
Why have you commented this out?
| @@ -57,6 +56,7 @@ dependencies: | |||
| intl_phone_number_input: ^0.7.4 | |||
| firebase_messaging: ^14.7.19 | |||
| shared_preferences: ^2.2.3 | |||
| win32: ^5.10.0 | |||
There was a problem hiding this comment.
Why is this dep updated?
|
As a issue resolving this issue has already been merged. I close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The application was using an outdated version of Gradle, which caused compatibility issues when setting up the project on devices using newer technologies. To resolve this, the Gradle version was updated, and the build files were modified to accommodate the changes.
Additionally, the application would crash on devices running Android 13 due to a missing receiver export declaration in one of the .kt files. This issue has now been addressed.
Proposed Changes
1.Upgraded the Gradle version to 8.3.
3.Fixed the MainActivity.kt file to comply with the updated Android protocols, ensuring the app runs seamlessly on newer devices.
Checklist