Correctly convert nerc-rates value to boolean #131
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes CCI-MOC#130 All values in nerc-rates are of type string and need to be correctly interpreted by the caller. Value for Limit New PI Credit to MGHPCC Partners is of type string and value "True" and is being passed as such to a method expecting a boolean. This change add a comparison with the string "True" to perform the conversion.
QuanMPhm
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
All values in nerc-rates are of type string and
need to be correctly interpreted by the caller.
Value for Limit New PI Credit to MGHPCC Partners is of type string and value "True" and is being passed as such to a method expecting a boolean.
This change add a comparison with the string "True" to perform the conversion.