The BU subsidy and New-PI credit can now be fetched from nerc_rates #148
+39
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user now has the option to provide a custom subsidy amount, or to fetch from nerc_rates. A `fetch_nerc_rates` function has been added to `utils.py`, as it is now commonly used.
QuanMPhm
force-pushed
the
147/subsidy_nerc_rates
branch
from
47db22e to
3d6a3ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147. In addition to fetching the BU subsidy, I decided to also fetch the New-PI credit. These values can optionally be provided through the CLI.
Also, some if-clauses have been refactored for cleanliness.