Add cluster UUID to orchestrated clusters #62
Conversation
|
@DanNiESh could you take a look at this one? Thanks! |
| "\n".join(node_info), | ||
| "\n".join(extra_info)]) | ||
|
|
||
| return ["Cluster", "Node", "Associated"], cluster_info |
There was a problem hiding this comment.
The current associated info contains all nodes' info within a cluster. Do we want to list each node and its associated data together?
There was a problem hiding this comment.
Oh, the way the node_info and extra_info is joined, it works pretty much as you say: each node's associated resources are printed on the same line
esiclient/v1/cluster/cluster.py
Outdated
| {'path': "/extra/esi_fip_uuid", | ||
| 'op': 'remove'}) | ||
| ironic_client.node.update(node.uuid, node_extra_update) | ||
| ironic_client.node.set_provision_state(node.uuid, 'deleted') | ||
|
|
||
| print("UNDEPLOY COMPLETE") |
There was a problem hiding this comment.
Can you add a message if no cluster_uuid is found, rather than showing users "UNDEPLOY COMPLETE"?
| "cluster_config_file", | ||
| metavar="<cluster_config_file>", | ||
| help=_("File describing the cluster configuration")) | ||
| "cluster_uuid", |
There was a problem hiding this comment.
Is cluster_uuid retrieved by listing clusters? Could you add the instructions in README file?
There was a problem hiding this comment.
Yep, it's already there in the openstack esi cluster undeploy documentation.
The cluster UUID allows for easy identification and cleanup of orchestrated clusters.
tzumainn
force-pushed
the
cluster-uuid
branch
from
67a122d to
4f059e7
Compare
The cluster UUID allows for easy identification and cleanup of orchestrated clusters.