Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setting.db_table_prefix variable #100

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Oct 26, 2024

Description

Adding setting.db_table_prefix so customers can optionally change all the table names with a prefix.

Additional Notes

Allowing customers to use an existing database for storing the MPI tables comes at a risk of not knowing what existing tables the customer might have in their database. To guarantee that the customer doesn't have any naming conflicts with the tables created by Record Linker, we can allow for an optional prefix ENV variable given them the opportunity to override the table names.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (0000ec5) to head (c94cd6f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   94.24%   94.28%   +0.04%     
==========================================
  Files          21       21              
  Lines        1025     1033       +8     
==========================================
+ Hits          966      974       +8     
  Misses         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley changed the title adding a config value for db_table_prefix add setting.db_table_prefix variable Oct 26, 2024
@ericbuckley ericbuckley self-assigned this Oct 26, 2024
@ericbuckley ericbuckley added the feature New feature or request label Oct 26, 2024
@ericbuckley ericbuckley marked this pull request as ready for review October 26, 2024 15:24
@ericbuckley ericbuckley merged commit 59d13a2 into main Oct 28, 2024
12 checks passed
@ericbuckley ericbuckley deleted the feature/table-prefix-config branch October 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants