-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New Parsers Framework #102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 95.33% 95.18% -0.16%
==========================================
Files 24 25 +1
Lines 1158 1183 +25
==========================================
+ Hits 1104 1126 +22
- Misses 54 57 +3 ☔ View full report in Codecov by Sentry. |
3a50035
to
8a81f1b
Compare
a259801
to
2c8747e
Compare
2c8747e
to
6402536
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbrinson-rise8 looks great, just made 1 small change to a docstring
Description
Abstract the parsing of FHIR out into its own module, as the linking algorithm should be input format agnostic. This approach will let us expand our supported formats for ELR and eCR ahead.
Related Issues
closes #80
Additional Notes
recordlinker.parsers.fhir
link/fhir
endpoint that acceptsfhir
bundles but response similar to the/link
endpointfhir
parser<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: