-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linking): implement possible match short-term #111
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 31 31
Lines 1375 1421 +46
=======================================
+ Hits 1314 1358 +44
- Misses 61 63 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
7a1c9f0
to
80abb86
Compare
222de38
to
ec6a3c8
Compare
Co-authored-by: Eric Buckley <[email protected]>
Co-authored-by: Eric Buckley <[email protected]>
Co-authored-by: Eric Buckley <[email protected]>
dfe8e50
to
1d25bcd
Compare
Co-authored-by: cbrinson-rise8 <[email protected]>
Co-authored-by: cbrinson-rise8 <[email protected]>
Co-authored-by: cbrinson-rise8 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @alhayward thanks for all your work on updating the unit tests!
Description
Example:
belongingness_ratio=[0.75, 0.9]
No Match
Possible Match
Match
include_multiple_matches=false
Match
include_multiple_matches=true
Related Issues
#91
Additional Notes
cluster_ratio
->belongingness_ratio
for claritybelongingness_ratio
definition fromAlgorithmPass
toAlgorithm
level (this was the DIBBs team's original intent)Algorithm.include_multiple_matches
boolean parameter to return multiple matchesbelongingness_ratio=[X, Y], if
Algorithm.include_multiple_matches=true, return all
resultswhere
belongingness_ratio >= X]. Assignperson_reference_id
of Person with highest Belongingness Ratio.LinkResponse
,LinkFhirResponse
)Algorithm.include_multiple_matches
)<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: