Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assets/ installation #121

Merged
merged 9 commits into from
Nov 7, 2024
Merged

fix assets/ installation #121

merged 9 commits into from
Nov 7, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Nov 6, 2024

Description

Moved assets/ to within the src/ directory so data files can be found after setup tools installs the project.

Related Issues

closes #117

Additional Notes

Additionally, removed the symbolic initial_algorithms link in tests/unit/assets, and opted to just load the file directly from src now that its being installed. Did a rename of "load_json_assets" to "load_test_json_assets" so others are aware that its explicitly loading testing assets.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (3e83d55) to head (5fcfa5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   95.13%   95.28%   +0.15%     
==========================================
  Files          29       29              
  Lines        1294     1293       -1     
==========================================
+ Hits         1231     1232       +1     
+ Misses         63       61       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review November 6, 2024 13:47
cbrinson-rise8
cbrinson-rise8 previously approved these changes Nov 6, 2024
@ericbuckley
Copy link
Collaborator Author

@cbrinson-rise8 I had to resolve some merge conflicts and made an additonal change (renamed recordlinker.utils.init to recordlinker.utils.path). Could you give this another look?

@ericbuckley ericbuckley merged commit 11e05d2 into main Nov 7, 2024
10 checks passed
@ericbuckley ericbuckley deleted the fix/117-install-assets branch November 7, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install assets with source code
2 participants