-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix assets/ installation #121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 95.13% 95.28% +0.15%
==========================================
Files 29 29
Lines 1294 1293 -1
==========================================
+ Hits 1231 1232 +1
+ Misses 63 61 -2 ☔ View full report in Codecov by Sentry. |
@cbrinson-rise8 I had to resolve some merge conflicts and made an additonal change (renamed recordlinker.utils.init to recordlinker.utils.path). Could you give this another look? |
Description
Moved assets/ to within the src/ directory so data files can be found after setup tools installs the project.
Related Issues
closes #117
Additional Notes
Additionally, removed the symbolic initial_algorithms link in tests/unit/assets, and opted to just load the file directly from src now that its being installed. Did a rename of "load_json_assets" to "load_test_json_assets" so others are aware that its explicitly loading testing assets.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: