Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstap script #145

Merged
merged 8 commits into from
Dec 11, 2024
Merged

bootstap script #145

merged 8 commits into from
Dec 11, 2024

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Dec 2, 2024

Description

Removing the git controlled .env file and automating the dev setup process with scripts/bootstrap.sh.

Additional Notes

Developers should be able to customize the .env file to their environment, and not have to worry about it changing whenever they pull new code. To make the developer setup process easy, the new bootstrap script will create a .env file if it doesn't exist, initialize a virtual environment if it doesn't exist, activate the virtual env and install the development python requirements.

  • Connection pooling parameters now have their default values set to None, so it will work with sqlite:///:memory:
  • The sessionmaker autocommit parameter was removed in sqlalchemy 2.0

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the automation Automation of processes label Dec 2, 2024
@ericbuckley ericbuckley self-assigned this Dec 2, 2024
@ericbuckley ericbuckley changed the title Feature/bootstrap bootstap script Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (7de3b70) to head (1e95c3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   97.14%   97.15%   +0.01%     
==========================================
  Files          30       30              
  Lines        1296     1301       +5     
==========================================
+ Hits         1259     1264       +5     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review December 3, 2024 16:38
@ericbuckley ericbuckley merged commit 3a7e58b into main Dec 11, 2024
12 checks passed
@ericbuckley ericbuckley deleted the feature/bootstrap branch December 11, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Automation of processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants