Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slack notifier open pulls #86

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Conversation

ericbuckley
Copy link
Collaborator

@ericbuckley ericbuckley commented Oct 17, 2024

Description

Fixing the slack notifier open pulls workflow to run on a schedule in main. The if: ${{ env.PR_LIST != '[]' }} comparison is too complex for a GH action step, we need to simplfy that a bit by doing more logic in the proceeding step.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (cbe8c78) to head (e7af618).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files          17       17           
  Lines         759      759           
=======================================
  Hits          704      704           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley self-assigned this Oct 17, 2024
@ericbuckley ericbuckley added the bug Something isn't working label Oct 17, 2024
@ericbuckley ericbuckley marked this pull request as ready for review October 17, 2024 22:20
@ericbuckley ericbuckley merged commit 5871cc5 into main Oct 18, 2024
8 checks passed
@ericbuckley ericbuckley deleted the fix/slack-notifier-open-pulls branch October 18, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants