-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto initialize algorithms in DB #89
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 93.26% 93.51% +0.24%
==========================================
Files 19 19
Lines 936 971 +35
==========================================
+ Hits 873 908 +35
Misses 63 63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a few quick questions & 1 suggestion. The justification for moving away from Alembic for now makes sense.
update to the basic algorithm description Co-authored-by: Alex Hayward <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Configuring the code to optionally load in initial algorithms after the tables have been initialized. Doing so, removes our needs now for having to use a database migration tool for the near future.
Related Issues
closes #57
Additional Notes
assets/initial_algorithms.json
with the two existing DIBBs algorithms. We can use this for our test cases, and also initializing a new database with the data, if the INITIAL_ALGORITHMS env variable is set. This also gives customers another option for managing their algorithms, in they can write their own and set the INITIAL_ALGORITHMS env variable to load that json file.schemas.pii.Features
. The blocking keys were capitalized, so making them both capitalized will hopefully reduce errors in writing the algorithm specs.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: