-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
structured logging #93
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 93.51% 94.24% +0.73%
==========================================
Files 19 21 +2
Lines 971 1025 +54
==========================================
+ Hits 908 966 +58
+ Misses 63 59 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions, LGTM. Is there an example of what this log will look like?
faa8aef
Description
Setting up the project to emit structured (JSON) logs in production so its easier to index and query in Splunk. Also adding a request correlation id to each request, so we can group together different logging messages.
Related Issues
closes #84
Additional Notes
recordlinker.linkage
module, as its no longer being used<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: