build_review_page_197 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arinkulshi-skylight
requested review from
knguyenrise8,
schreiaj and
zdeveloper
knguyenrise8
previously approved these changes
Sep 17, 2024
zdeveloper
reviewed
Sep 17, 2024
| await scrollContainer.evaluate((el) => el.scrollBy(0, 100)); | ||
| const afterScroll = await scrollContainer.evaluate((el) => el.scrollTop); | ||
|
|
||
| await expect(afterScroll).toBeGreaterThan(beforeScroll); |
There was a problem hiding this comment.
await is not needed here, toBeGreaterThan doesnt return a promise
zdeveloper
reviewed
Sep 17, 2024
| test("Displays extracted data with overall confidence score", async ({ | ||
| page, | ||
| }) => { | ||
| const extractedDataHeader = await page.getByRole("heading", { |
There was a problem hiding this comment.
await is not needed here
zdeveloper
previously approved these changes
Sep 17, 2024
arinkulshi-skylight
dismissed stale reviews from zdeveloper and knguyenrise8
via
de2210c
zdeveloper
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
#197