Add Click-To-Edit functionality #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates SortableTable to pass in index and entire row data into formatters Use SortableTable on Review page Create custom formatter for adding exclamation icon and coloring rows red
Adds the click to edit functions for the review and edit page Return will commit changes Escape will revert changes since last commit Clicking outside of the text box will commit changes If there are errors Submit button on review page will be disabled Hovering over content will display icon (transition of icon will respect reduce motion preferences) Minor tsconfig tweak to remove error when importing syntheticDefaultImports Fix bug with Sortable Table passing in wrong index to formatter functions
zdeveloper
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the click to edit functions for the review and edit page
If there are errors Submit button on review page will be disabled
Hovering over content will display icon (transition of icon will respect
reduce motion preferences)
Minor tsconfig tweak to remove error when importing
syntheticDefaultImports
Use SortableTable on Review page
Update SortableTable to pass formatter function (value, idx, row) to allow more complex formatting
Fix bug with Sortable Table passing in wrong index to formatter
functions
Demo:
