Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement alignment service #313

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Implement alignment service #313

merged 12 commits into from
Oct 28, 2024

Conversation

jonchang
Copy link
Collaborator

@jonchang jonchang commented Oct 10, 2024

Description

Implement the alignment service. This can now be accessed through the ImageAlignment.align method and supports two backends (four-point alignment and image homography)

Screenshots (if applicable)

Related Issues

#226

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

@jonchang
Copy link
Collaborator Author

This will likely need to be run jointly with segmentation, as the segmentation templates currently have 'burned-in' color boxes and that needs to be excluded somehow prior to alignment

@jonchang
Copy link
Collaborator Author

Running alongside segmentation now, needs more aggressive filtering to pass tests as some of the test files are very small and don't have enough distinguishing features to properly do image homography

@jonchang
Copy link
Collaborator Author

two issues so far-

  • needs to handle case where we are relying on small, already segmented images to test the ocr pipeline
  • needs to handle the case where the test data already has segmentation areas 'burned in' to the image rather than getting passed in a reference plus coordinates for segment areas

@jonchang jonchang marked this pull request as ready for review October 25, 2024 23:33
@jonchang
Copy link
Collaborator Author

  • reorganized the code, all backends are now in ocr.services.alignment.backends
  • added tests that check both backends for alignment capability

@jonchang jonchang added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 8c5e20a Oct 28, 2024
2 checks passed
@jonchang jonchang deleted the alignment-service branch October 28, 2024 17:02
@jonchang
Copy link
Collaborator Author

Thanks Andrew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants