Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RV-447): Add toolbar to extraction flows #454

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

knguyenrise8
Copy link
Collaborator

Description

Adds tool bar to extraction flow

Screenshots (if applicable)

Dec-05-2024 08-08-45

Related Issues

[Link any related issues or tasks from your project management system.]

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

Copy link
Collaborator

@marycrawford marycrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. However, have a recommended revision for the imageToTextURL value.

@@ -45,7 +45,7 @@ export const ImageToText = async (
labels: JSON.stringify(fieldNames),
});

const imageToTextURL = `${middlewareURL}api/image_file_to_text`;
const imageToTextURL = `${middlewareURL}image_to_text`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put dashes (-) instead of underscores (_) here? For example the url will come back as http://localhost:8000/image-to-text versus http://localhost:8000/image_to_text.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change the URL in the middleware at a later point. For now this should be ok.

Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knguyenrise8 knguyenrise8 added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit e504858 Dec 5, 2024
3 checks passed
@knguyenrise8 knguyenrise8 deleted the fix/RV-447-add-tool-bar-extraction branch December 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants