Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove extra slash in middleware endpoint and clean up #486

Merged
merged 1 commit into from
Dec 13, 2024
Merged

remove extra slash in middleware endpoint and clean up #486

merged 1 commit into from
Dec 13, 2024

Conversation

zdeveloper
Copy link
Collaborator

@zdeveloper zdeveloper commented Dec 13, 2024 •
edited
Loading

Description

  • Remove extra slash in middleware endpoint
  • Remove duplicate code
  • Make the variable not have have a slash at the end for better readability

Screenshots (if applicable)

notice the double slashes
image

Checklist

  • The title of this PR is descriptive and concise.
  • My changes follow the style guidelines of this project.
  • I have added or updated test cases to cover my changes.
  • I've let the team know about this PR by linking it in the review channel

arinkulshi-skylight
arinkulshi-skylight approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@arinkulshi-skylight arinkulshi-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arinkulshi-skylight arinkulshi-skylight added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 82c5224 Dec 13, 2024
3 checks passed
@arinkulshi-skylight arinkulshi-skylight deleted the zedd/remove-extra-slash-endpoint branch December 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinkulshi-skylight arinkulshi-skylight arinkulshi-skylight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdeveloper @arinkulshi-skylight