Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDWA-OCR-72] Install OCR into an executable #73

Closed
wants to merge 8 commits into from

Conversation

derekadombek
Copy link
Collaborator

@derekadombek derekadombek commented Apr 11, 2024

Pull Request

Description

This gives us the option to run OCR as an executable as well. We are still able to run the service with poetry like normal. This is just a start but this puts us in the right direction for future releasing and adding OCR to other tooling like RPA solutions

Related Issues

#72

Additional Notes

[Add any additional context or notes that reviewers should know about.]

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@@ -0,0 +1,4 @@
{
Copy link
Collaborator Author

@derekadombek derekadombek Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied these into the main service directory as well but not necessarily sure how I feel about these being in two different places even though I know they might not even be located in the repo in the future anyways but if we do want to only use them from the og test directory ATM, I will need to move the pyinstaller.py function to the root dir.

Copy link
Collaborator Author

@derekadombek derekadombek Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to this, I tried moving the pyinstaller.py to the root OCR directory just to try it without needing the duplicate asset files and it would not work properly ATM with how we ingesting the asset files from the local directories and cannot backout of paths(ie. ..) like we currently are doing with the tests/ directory. So the best way to use this right now for running main.py with or without an executable is to put separate assets in the ocr dir.

@zdeveloper zdeveloper closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants