-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruff lint and style checks #76
Conversation
We aren't linting or formatting dedupe work.
@derekadombek ready for review, I think. It should only check in the ocr/ directory now. dedupe/ can opt in by specifying something in |
I personally don't mind either way how the workflows get divided. This will work but It's usually good to keep things uniform and standard across a repo and sticking with one method of doing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Pull Request
Description
This implements the ruff formatter and linter for automatic style checks using github actions.
Related Issues
See https://github.com/CDCgov/IDWA/blob/main/open_practices.md#recommended-practices, configuration for linters.
Additional Notes
Line length 118 was chosen because (at least last time I checked) it is the maximum width that the github diff viewer has before soft wrapping.
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: