Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds install-julia local action #17

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Adds install-julia local action #17

merged 6 commits into from
Feb 9, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Feb 9, 2024

This PR adds a install-julia action that uses caching to speed up julia installation and julia package installation. It also tweaks precommit configuration settings to give fewer false positives with julia.

I tested that the precommit action now works as expected (including with caching) locally using act.

In order to get pecommit to pass I ran it across all files (pre-commit run --all-files)

@seabbs seabbs mentioned this pull request Feb 9, 2024
Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out.

If possible, I'd like to keep the python and R pre-commit hooks. I imagine we'll have some plotting or glue code pretty soon?

@seabbs
Copy link
Collaborator Author

seabbs commented Feb 9, 2024

If possible, I'd like to keep the python and R pre-commit hooks. I imagine we'll have some plotting or glue code pretty soon?

I killed these for now as the R ones especially were failing due to the lack of Rscript and I didn't want to add a install r step that would just slow down CI and not be used.

I agree we should add back in as soon as there is any R or python code and am happy to cover this issue when needed.

@seabbs seabbs merged commit 8085706 into main Feb 9, 2024
1 check passed
@seabbs seabbs deleted the github-actions branch February 9, 2024 23:47
@zsusswein
Copy link
Collaborator

Fair enough. Thanks for thinking it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants