Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update epiaware and make necessary changes #262

Merged
merged 3 commits into from
Jun 6, 2024
Merged

update epiaware and make necessary changes #262

merged 3 commits into from
Jun 6, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

@SamuelBrand1 SamuelBrand1 commented Jun 6, 2024 •
edited
Loading

This PR updates the deps of EpiAware to latest version by updating [compat] first. I've made the decision here to pin on minor version again except for packages that come with base Julia (including Julia itself) which I'm stating have to have >= 1.9.

MvNormal constructor

Following from this it turns out that

MvNormal(I(n))

is no longer a valid constructor for our purposes. The reason is that I(n) constructs a Diagonal{Integer} and now Turing is sensitive to the eltype of the constructor of MvNormal. This leads to InexactError chucks later on.

I've replaced with

MvNormal(n, one(eltype(...)))

although potentially other options are available.

Closes #261 .

@SamuelBrand1 SamuelBrand1 requested a review from seabbs June 6, 2024 10:35
@SamuelBrand1 SamuelBrand1 linked an issue Jun 6, 2024 that may be closed by this pull request
Update EpiAware to depend on more recent version of Turing.jl and >= in compat #261
Closed
@SamuelBrand1 SamuelBrand1 mentioned this pull request Jun 6, 2024
Open
seabbs
seabbs approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense. LGTM

@seabbs seabbs enabled auto-merge (squash) June 6, 2024 12:23
@seabbs seabbs merged commit 5156b2b into main Jun 6, 2024
10 checks passed
@seabbs seabbs deleted the 261-update-epiaware-to-depend-on-more-recent-version-of-turingjl-and-=-in-compat branch June 6, 2024 12:53
SamuelBrand1 added a commit that referenced this pull request Jun 7, 2024
@SamuelBrand1
Squashed commit of the following:
6b8398b 
commit e73fd9e
Author: Samuel Brand <[email protected]>
Date:   Thu Jun 6 11:40:25 2024 -0400

    update pipeline deps and minor test catches (#263)

commit 5156b2b
Author: Samuel Brand <[email protected]>
Date:   Thu Jun 6 08:53:57 2024 -0400

    update epiaware and make necessary changes (#262)

    * Update compat

    * Change MvNormal constructor

    * Update tests because of type passing to MvNormal
@SamuelBrand1 SamuelBrand1 mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update EpiAware to depend on more recent version of Turing.jl and >= in compat
2 participants
@SamuelBrand1 @seabbs