Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestItemRunner.jl to enable VScode testing integration and support running individual unit tests #27

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Feb 12, 2024

Adds TestItemRunner.jl and checks it works with both vscode testing framework and via test. Also cleans up some duplicate tests and improves test names.

This change was made as TestItemRunner works with the vscode testing framework and allows users in other IDEs to run specific tests using a Julia macro.

Base automatically changed from add-testing-ci to main February 12, 2024 11:52
@seabbs seabbs changed the title Add TestItemRunner Add TestItemRunner.jl Feb 12, 2024
Copy link
Collaborator

@zsusswein zsusswein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two asks:

  1. Can you fix the broken CI? From a quick glance, it looks like TestItems is added successfully but TestItemRunner needs to be added as well
  2. Can you document in a commit message or something why you made the switch? I can guess, but there's no linked isssue so it's not obvious.

@seabbs seabbs requested a review from zsusswein February 12, 2024 13:42
@seabbs seabbs changed the title Add TestItemRunner.jl Add TestItemRunner.jl to enable VScode testing integration and support running individual unit tests Feb 12, 2024
@seabbs seabbs merged commit 4b33059 into main Feb 12, 2024
2 checks passed
@seabbs seabbs deleted the add-testitem branch February 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants