Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Switch to fork of benchmarkCI #520

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Patch: Switch to fork of benchmarkCI #520

merged 6 commits into from
Nov 11, 2024

Conversation

SamuelBrand1
Copy link
Collaborator

The goal of this is to switch main to using the fork of benchmarkCI and contribute to closing #511 .

@SamuelBrand1 SamuelBrand1 requested a review from seabbs November 11, 2024 15:38
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

import Pkg
Pkg.activate(temp=true)
Pkg.add(url="https://github.com/CDCgov/Rt-without-renewal", rev="new-benchmark-ci", subdir="EpiAware")
using EpiAware

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (0b6a162) to head (adf5c3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #520   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files          53       53           
  Lines         753      753           
=======================================
  Hits          675      675           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs enabled auto-merge November 11, 2024 16:23
@seabbs
Copy link
Collaborator

seabbs commented Nov 11, 2024

As in add a source here: https://github.com/CDCgov/Rt-without-renewal/blob/main/benchmark/Project.toml

So that this uses the correct package both in CI and when called locally

@SamuelBrand1 SamuelBrand1 requested a review from seabbs November 11, 2024 16:30
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow a surprising pain! Nice fix

@seabbs seabbs added this pull request to the merge queue Nov 11, 2024
@seabbs seabbs removed this pull request from the merge queue due to a manual request Nov 11, 2024
@seabbs seabbs merged commit 67d5072 into main Nov 11, 2024
10 of 11 checks passed
@seabbs seabbs deleted the new-benchmark-ci branch November 11, 2024 17:39
seabbs added a commit that referenced this pull request Dec 5, 2024
* Patch: Switch to fork of benchmarkCI (#520)

* patch to fork of benchmarkCI

* put fork version of BenchmarkCI in [sources]

* swap order

* add EpiAware [source]

* fix path

* rm benchmarkCI from project

* Patch fix: add `Manifest.toml` to benchmarking (#524)

* trigger

* Update benchmark.yaml

* Update benchmark.yaml

* commit benchmark Manifest

* try alternate approach

* Update benchmark.yaml

* Update EpiMethod.jl

* Update benchmark.yaml

* change baseline to origin/main

* remove trigger

* rm other trigger

* Issue 465: Add an infection generating model for ODE problems (#510)

* CompatHelper: bump compat for Turing to 0.35 for package EpiAware, (drop existing compat) (#516)

* CompatHelper: bump compat for Turing to 0.35 for package EpiAware, (drop existing compat)

* Update Project.toml

* fix Project.toml

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Samuel Brand <[email protected]>
Co-authored-by: Samuel Brand <[email protected]>

* CompatHelper: bump compat for DynamicPPL to 0.30 for package EpiAware, (drop existing compat) (#528)

Co-authored-by: CompatHelper Julia <[email protected]>

* rename IDD -> IID

* rename test file

* Issue 529: Create null Latent model (#530)

* Null Latent model

* Null Latent model

* fix doctest

* fix generate_epiaware unit tests

New usage of RW

* fix turing method test

underlying std of step size changed name

* fix broadcast test

Underlying std param changed name

* fix HN unit test

Default std prior had changed

* fix AR unit tests

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
seabbs added a commit that referenced this pull request Dec 12, 2024
* draft MA method

* draft MA methd

* use IDD for epsilon in all models

* add MA benchmark

* Add docs and  tests for IDD

* make episilon_t a arg of the latent model constructors

* improve MA correctness

* fully import EpiAwareUtils

* add a test for IDD

* add tests for MA.jl

* add doc tests and unit tests + start on helper fn

* more updatres to AR appraoc

* chase down partial arg changes

* clean up AR

* clean up and add arma and arima helpers

* Contributions towards Arma/Arima models (#531)

* Patch: Switch to fork of benchmarkCI (#520)

* patch to fork of benchmarkCI

* put fork version of BenchmarkCI in [sources]

* swap order

* add EpiAware [source]

* fix path

* rm benchmarkCI from project

* Patch fix: add `Manifest.toml` to benchmarking (#524)

* trigger

* Update benchmark.yaml

* Update benchmark.yaml

* commit benchmark Manifest

* try alternate approach

* Update benchmark.yaml

* Update EpiMethod.jl

* Update benchmark.yaml

* change baseline to origin/main

* remove trigger

* rm other trigger

* Issue 465: Add an infection generating model for ODE problems (#510)

* CompatHelper: bump compat for Turing to 0.35 for package EpiAware, (drop existing compat) (#516)

* CompatHelper: bump compat for Turing to 0.35 for package EpiAware, (drop existing compat)

* Update Project.toml

* fix Project.toml

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>
Co-authored-by: Samuel Brand <[email protected]>
Co-authored-by: Samuel Brand <[email protected]>

* CompatHelper: bump compat for DynamicPPL to 0.30 for package EpiAware, (drop existing compat) (#528)

Co-authored-by: CompatHelper Julia <[email protected]>

* rename IDD -> IID

* rename test file

* Issue 529: Create null Latent model (#530)

* Null Latent model

* Null Latent model

* fix doctest

* fix generate_epiaware unit tests

New usage of RW

* fix turing method test

underlying std of step size changed name

* fix broadcast test

Underlying std param changed name

* fix HN unit test

Default std prior had changed

* fix AR unit tests

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Sam Abbott <[email protected]>

* revert define_ namming

* clean out repeated utils from merge

* fix MA tests

* fix RW tests - feel made about RandomWalk vs AR naming

* fix remaining unit tests that aren't doctests

* update latent recovery test

* try and fix doctests automatically

* update all doctests to output nothing - this is awful

* add doctests for arima and arma

* fix doctest

* clean up deps

* update replication studies

* add interface tests for combination functions and add benchmarks

* add some basic theoretical properties tests

* name change IDD -> IID benchmarks

* moving all the constructors because this PR is too contained

* catch missing using

* update iid benchmark:

* update extraction

* remove old param namme from case study

* get the dot

* get the dot

* fix initial guess point for MAP opt

* Update index.jl

* add a compile time branch for HN

* add a compile time branch for HN

* update test

* add a new constructor to get old default behaviour

* update docs

* update docs - using the structs for priors is very brittle

* reorder prior plots

---------

Co-authored-by: Samuel Brand <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Samuel Brand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants