-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the prior interface for make epi model inference #61
Improve the prior interface for make epi model inference #61
Conversation
…along with updated unit tests and inference run checking
…t tests and inference test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice I think! As discussed f2f we may move away from the NamedTuple
to instead use argument splitting. Only outstanding note is that the updated diagram should also go in the README in this PR I think
As I have caused the pain happy to handle the conflicts when #62 is merged in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 117 123 +6
=========================================
+ Hits 117 123 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Goals
This PR aims to address modularity problems for priors discussed here #45 . The goal is to have the choice of priors for a sub-process or sub-model "live" with the
Turing
model definition of the sub-process or sub-model within a struct.API changes
make_epi_inference_model
constructor for the overallTuring
model now requires positional arguments require args of typeLatentProcess
for the latent process andObservationModel
for the observation model.random_walk
anddelay_observations
are no longer exported byusing EpiAware
.delay_observations_model
creates anObservationModel
with basic delayed observation model here. If priors are not supplied the defaults are used.random_walk_process
creates aLatentProcess
with basic random walk model here.Proposed
EpiAware
model diagramCloses #45