Changed process priors into Dicts rather than NamedTuples #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sier specification of expected type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 123 123
=========================================
Hits 123 123 ☔ View full report in Codecov by Sentry. |
…sier specification of expected type
seabbs
force-pushed
the
72-replace-named-iterator-for-priors-with-dict-objects
branch
from
abca811 to
0e747e3
Compare
… of https://github.com/CDCgov/Rt-without-renewal into 72-replace-named-iterator-for-priors-with-dict-objects
seabbs
deleted the
72-replace-named-iterator-for-priors-with-dict-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
As discussed in #72 , it is simpler to reason on expected type of our iterator prior distributions if they are specified as a
Dict; that is we know the dictionary must be typedDict{Symbol,D<:Distribution}.This PR enforces this standard and updates the default prior constructors and unit tests. Splatting to lower level functions is agnostic to this change.
Closes #72